Final JsHint Fix

[corneadoug]

Bad Ass JsHint

For long time already, we are having problems with JsHint... Or should I say, with the fact that nobody is checking it out.

One of the reason is that JsHint is not running on build by default (because every warning is currently a blocker), and because of that, every pull request is adding to the long list of errors when we run grunt jshint

Since I am a bit tired of spending my time fixing other people JsHint errors, I decided to take care of it once and for all. (currently 96 errors)

In this pull request, we will try to fix and define multiple things related to JsHint:

• Having a JsHint configuration file
• Pushing confirm, alert, jQuery etc... to the JsHint configuration file
• Trying to have a warnings + errors system (warnings would not be a blocker)
• Define our JsHint rules, and which one are warnings or errors
• Having a Wiki page regarding JsHint
• Make JsHint run at every change on grunt serve
• Make JsHint run at every build (No fix, no build, no merge)

For example:

• 'i' is already defined should be an error
• 'config' is defined but never used. should be a warning

--> Because it is always nice to keep every parameters in the callback functions, even if we don't use them

[swkimme]

You would know we're trying to add Typescirpt,
since Typescript is static type language and should be much more stable than javascript, the advantage of Lint tool is quite smaller I guess.

Still I see JsHint is useful, but JsHint is throwing some error with Typescript-generated js files. I think we need to reconsider JSHint with Typescript. Are there any alternative Lint tool that goes well with Typescript?

[corneadoug]

@swkimme Right,
Since JsHint was also there to check a bit of code style, it could be nice to find both a linter and a style checker for Typescript (so that we would check possible code errors, and force a coding style). Palantir seems to have quite a lot of tools including tslint: https://github.com/palantir/tslint (that have a grunt and eclipse plugin)

for a code style checker I found a typescript styleCop project, could be a good lead to search a nice tool since it seems that StyleCop is pretty popular in C#: https://github.com/Diullei/TS-StyleCop