Improve spark interpreter parameter handling #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ready to be merged |
Contributor
|
Great! let me test it |
Contributor
|
Works great! |
Leemoonsoo
added a commit
that referenced
this pull request
Jan 29, 2015
Improve spark interpreter parameter handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#235 Introduces new way of passing configuration parameter to spark.
However, it overrides parameters that defined in old way.
ie. if user sets spark parameter in environment variable, like
export ZEPPELIN_JAVA_OPTS=-Dspark.cores.max=10it's simply ignored.To minimize user experience changes, this PR now reads those old settings and uses it as a default value of new parameter setting, for next three parameters
"spark.master", "spark.executor.memory", "spark.cores.max"