This repository has been archived by the owner on Jul 3, 2020. It is now read-only.
[3.0] AssertionInterface is now using an AuthorizationContext #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #240 |
| @@ -55,6 +56,11 @@ class AuthorizationService implements AuthorizationServiceInterface | |||
| protected $assertions = []; | |||
|
|
|||
| /** | |||
| * @var string | |||
| */ | |||
| protected $contextClass = 'ZfcRbac\Assertion\AuthorizationContainer'; | |||
There was a problem hiding this comment.
A classic facepalm, forgot to remove that ;D
| * @return bool | ||
| */ | ||
| public function assert(AuthorizationService $authorizationService); | ||
| public function assert(AuthorizationServiceInterface $authorizationService, AuthorizationContext $context); |
There was a problem hiding this comment.
I'm not really for making the context mandatory. Sometimes you actually don't need context, isn't it? So I think AuthorizationContext $context = null is better.
There was a problem hiding this comment.
$context->getContext() may indeed be null, $context->getPermission() has always a value, so I have to disagree. Also, I do not understand how that should work within the authservice, which passes the context container always.
|
I've created a develop branch. Could you make the PR against the develop branch? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BC, when moving to 3.0 we should include this in Upgrade.md!