Fix electron issue with executableName specifying

electron-userland/electron-builder#6962 electron/electron#34253
ZIMkaRU · Dec 14, 2023 · 5c7fb5b · 5c7fb5b
1 parent aaf9e26
commit 5c7fb5b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/electron-builder-config.js b/electron-builder-config.js
@@ -59,7 +59,6 @@ module.exports = {
   extends: null,
   asar: false,
   productName: 'Bitfinex Report',
-  executableName: 'bfx-report-electron',
   artifactName: 'BitfinexReport-${version}-x64-${os}.${ext}',
   appId: 'com.bitfinex.report',
   publish: {
@@ -74,6 +73,7 @@ module.exports = {
     updaterCacheDirName: 'bfx-report-electron-updater'
   },
   linux: {
+    executableName: 'app',
     description: 'Bitfinex Report',
     maintainer: '<bitfinex.com>',
     category: 'Network',

diff --git a/scripts/node/make-mac-app-update-yml.js b/scripts/node/make-mac-app-update-yml.js
@@ -19,7 +19,7 @@ if (
 const ymlName = 'app-update.yml'
 const ymlPath = path.join(
   cwd,
-  'dist/mac/bfx-report-electron.app/Contents/Resources',
+  'dist/mac/Bitfinex Report.app/Contents/Resources',
   ymlName
 )
 

diff --git a/src/auto-updater/bfx.mac.updater.js b/src/auto-updater/bfx.mac.updater.js
@@ -53,7 +53,7 @@ class BfxMacUpdater extends MacUpdater {
 
       const root = path.join(appDir, '../../..')
       const dist = path.join(root, '..')
-      const exec = path.join(root, 'Contents/MacOS/bfx-report-electron')
+      const exec = path.join(root, 'Contents/MacOS/Bitfinex Report')
 
       await fsPromises.rm(root, { recursive: true })
 

diff --git a/wdio.conf.js b/wdio.conf.js
@@ -2,13 +2,13 @@ process.env.TEST = 'true'
 
 const getAppBinaryPath = () => {
   if (process.platform === 'win32') {
-    return './dist/win-unpacked/bfx-report-electron.exe'
+    return './dist/win-unpacked/Bitfinex Report.exe'
   }
   if (process.platform === 'darwin') {
-    return './dist/mac/bfx-report-electron.app/Contents/MacOS/bfx-report-electron'
+    return './dist/mac/Bitfinex Report.app/Contents/MacOS/Bitfinex Report'
   }
   if (process.platform === 'linux') {
-    return './dist/linux-unpacked/bfx-report-electron'
+    return './dist/linux-unpacked/app'
   }
 }