Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uZhW8Rgl - support for the Decaf377 - RC1 #17

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

uZhW8Rgl
Copy link

add support for the Decaf377 an embedded elliptic curve of the BLS12_377

This pull request fixes #15.

Description

  • added Decaf377 support
  • added a unit test

Additional context

See issue #15.

@alv-around alv-around self-requested a review March 22, 2024 12:34
Copy link

@alv-around alv-around left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :)

@alv-around alv-around merged commit 295b145 into ZK-Plus:main Mar 22, 2024
5 checks passed
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.68%. Comparing base (68f0a85) to head (8b8a8a3).

Files Patch % Lines
znakes/eddsa.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   56.79%   57.68%   +0.89%     
==========================================
  Files           7        7              
  Lines         817      839      +22     
==========================================
+ Hits          464      484      +20     
- Misses        353      355       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support for the Decaf377 an embedded elliptic curve of the BLS12_377
2 participants