Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and add possibility to override Moshi version applied by IR plugin #660

Closed

Conversation

plnice
Copy link
Contributor

@plnice plnice commented Sep 5, 2024

Two commits here:

  1. Bump Moshi version applied by IR plugin from 1.13.0 to 1.15.1. 1.13.0 was released on 2021-12-08 and 1.15.1 was released on 2024-01-30, I think it makes sense to apply newest version. Also 1.15.1 is already widely used throughout the MoshiX repository.
  2. Add possibility to override the version in case of somebody needs older or newer one, if it's there. It should be convenient to do this by utilizing simple property in Gradle plugin extension. Moved default value to property's convention as it makes sense to set the default version value as early as possible, and then only read it.

@plnice plnice force-pushed the plnice/bump-and-override-moshi-version branch from da0bcfa to 6a4aa60 Compare September 5, 2024 16:12
@plnice plnice changed the title Bump and override Moshi version applied by IR plugin Bump and add possibility to override Moshi version applied by IR plugin Sep 5, 2024
Copy link
Owner

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'm not sure I want to do this actually. It starts to blur the line of this plugin acting as dependency management middleware. I'd be open to, instead, making the auto-application of the moshi dependency a disable-able behavior though. We intentionally only apply the minimum required version at the moment.

@plnice
Copy link
Contributor Author

plnice commented Sep 5, 2024

Got it - in my project we apply Moshi manually anyway to not depend on transitive dependency in our source code (the rationale of opening this PR was to remove adding 1.13.0 unnecessarily if we use 1.15.1). Let me open another PR with possibility to disable auto-application of Moshi dependency

@plnice plnice closed this Sep 5, 2024
@plnice plnice deleted the plnice/bump-and-override-moshi-version branch September 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants