Introduce AnvilKspOptionsProvider #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for `CommandLineArgumentProvider` to work correctly, it needs to internally track its inputs as a managed object. Prior to this, changes to providers would not actually invalidate a KSP task's inputs and result in incorrect cache hits since the pluginOptions themselves under the hood are deemed internal and ignored. This fixes it by creating a new `AnvilKspOptionsProvider` managed type with a `MapProperty` that tracks the inputs. This is appropriately wired in `KspTask` as a `@Nested` input, which then fixes this cache hit issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for
CommandLineArgumentProviderto work correctly, it needs to internally track its inputs as a managed object. Prior to this, changes to providers would not actually invalidate a KSP task's inputs and result in incorrect cache hits since the pluginOptions themselves under the hood are deemed internal and ignored.This fixes it by creating a new
AnvilKspOptionsProvidermanaged type with aMapPropertythat tracks the inputs. This is appropriately wired inKspTaskas a@Nestedinput, which then fixes this cache hit issue.