[feat-216] support for sorting maps/songs and playlists #601
Conversation
silentrald
changed the title
silentrald
force-pushed
the
feat/216
branch
3 times, most recently
from
c3fe24d to
2e4db8c
Compare
|
* linted/auto-formatted sorter.service.ts files * changed generics.type to comparator.type
* also applied change to model filter ui
| @@ -182,22 +282,43 @@ export function MapsPlaylistsPanel({ version, isActive }: Props) { | |||
| <BsmDropdownButton className="h-full relative z-[1] flex justify-center" buttonClassName="flex items-center justify-center h-full rounded-full px-2 py-1 whitespace-nowrap" icon="filter" text="pages.version-viewer.maps.search-bar.filters-btn" textClassName="whitespace-nowrap" withBar={false}> | |||
| {( | |||
| tabIndex === 0 ? ( | |||
| <FilterPanel className="absolute top-[calc(100%+3px)] origin-top w-[500px] h-fit p-2 rounded-md shadow-md shadow-black" filter={mapFilter} onChange={setMapFilter} /> | |||
| <FilterPanel className="absolute top-[calc(100%+3px)] origin-top w-[500px] h-fit p-2 rounded-full shadow-md shadow-black" filter={mapFilter} onChange={setMapFilter} /> | |||
| ) : ( | ||
| <LocalPlaylistFilterPanel className="absolute top-[calc(100%+3px)] origin-top w-[300px] h-fit p-2 rounded-md shadow-md shadow-black" filter={playlistFilter} onChange={setPlaylistFilter} /> | ||
| <LocalPlaylistFilterPanel className="absolute top-[calc(100%+3px)] origin-top w-[300px] h-fit p-2 rounded-full shadow-md shadow-black" filter={playlistFilter} onChange={setPlaylistFilter} /> |
| onClick={handleAscendingClick} | ||
| /> | ||
|
|
||
| <BsmSelect |
There was a problem hiding this comment.
For playlists, the NPS sort is way too long, so instead of Notes per Second, use NPS.
Also, I think we can remove Max and Min and keep only NPS. If users want playlists with the minimum NPS, they can simply reverse the sort 🤔
| import { Comparator, Comparison } from "shared/models/comparator.type"; | ||
| import { BsmLocalMap } from "shared/models/maps/bsm-local-map.interface"; | ||
|
|
||
| export class MapsSorterService { |
There was a problem hiding this comment.
I think this class doesn't need to be a Service; it should be a regular class
Since this class can be used by both the back-end and front-end, you can place it in ./shared/models/maps/
If you want to avoid duplicating comparators in memory, you can use a static variable. 😉
| import { Comparator, Comparison } from "shared/models/comparator.type"; | ||
| import { LocalBPListsDetails } from "shared/models/playlists/local-playlist.models"; | ||
|
|
||
| export class PlaylistsSorterService { |
There was a problem hiding this comment.
You can even create an abstract class for these two 🤔
In the future, it's possible we might want to sort other types of content (models, etc, who knows), and we could create another Sorter class extending the abstract class 🤷
There was a problem hiding this comment.
Was thinking along the lines of just of using a default sorter class since the two classes literally just share the same logic, just different variable values. The class can still be extended if we need any special thing for the sorter to do in any case.
|
|
Thanks @silentrald ! ❤️ |
Closes #216, Closes #329, Closes #574
UI change as of e3d27e4
