-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] remove auto update for linux builds #685
[bugfix] remove auto update for linux builds #685
Conversation
} | ||
{outdated && | ||
<span className="bg-main-color-1 text-white dark:text-black dark:bg-white rounded-full ml-1 text-[10px] italic px-1 uppercase h-3.5 font-bold"> | ||
Outdated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A missing translation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, although discussed in the discord that it should be changed to "New version available" although the word "Outdated" is concise enough. Wdyt?
And the color should be black on a red or yellow bg. Or you prefer just the white bg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated
should do the work
For the color, try to use the bg-warning-xxx
for the background color (adjust the text color if needed)
@@ -76,7 +108,7 @@ export default function TitleBar({ template = "index.html" }: { template: AppWin | |||
<div id="drag-region" className="grow basis-0 h-full"> | |||
<div id="window-title" className="pl-1"> | |||
<span className="text-gray-800 dark:text-gray-100 font-bold text-xs italic">BSManager</span> | |||
{previewVersion && <span className="bg-main-color-1 text-white dark:text-black dark:bg-white rounded-full ml-1 text-[10px] italic px-1 uppercase h-3.5 font-bold">{previewVersion}</span>} | |||
<TitleBarTags ipcService={ipcService} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a reason to pass the service as a props, instead of using the useService
hook directly in the component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh yeah, forgot it was a singleton. Might be better to do that then.
7a35cd2
to
035b992
Compare
* better ui for outdated tag * refactored TitleBarTags to not pass the singleton in its attribs
035b992
to
0b28cd6
Compare
Quality Gate passedIssues Measures |
Thanks @silentrald 🙌 |
Since linux users update their application thru the package manager, disabled auto updates thru BSManager to not conflict or create issues with updates.