Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] remove auto update for linux builds #685

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

silentrald
Copy link
Contributor

@silentrald silentrald commented Dec 10, 2024

Since linux users update their application thru the package manager, disabled auto updates thru BSManager to not conflict or create issues with updates.

image

}
{outdated &&
<span className="bg-main-color-1 text-white dark:text-black dark:bg-white rounded-full ml-1 text-[10px] italic px-1 uppercase h-3.5 font-bold">
Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A missing translation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, although discussed in the discord that it should be changed to "New version available" although the word "Outdated" is concise enough. Wdyt?

And the color should be black on a red or yellow bg. Or you prefer just the white bg.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated should do the work
For the color, try to use the bg-warning-xxx for the background color (adjust the text color if needed)

@@ -76,7 +108,7 @@ export default function TitleBar({ template = "index.html" }: { template: AppWin
<div id="drag-region" className="grow basis-0 h-full">
<div id="window-title" className="pl-1">
<span className="text-gray-800 dark:text-gray-100 font-bold text-xs italic">BSManager</span>
{previewVersion && <span className="bg-main-color-1 text-white dark:text-black dark:bg-white rounded-full ml-1 text-[10px] italic px-1 uppercase h-3.5 font-bold">{previewVersion}</span>}
<TitleBarTags ipcService={ipcService} />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reason to pass the service as a props, instead of using the useService hook directly in the component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh yeah, forgot it was a singleton. Might be better to do that then.

@silentrald silentrald force-pushed the bugfix/disable-linux-auto-update branch from 7a35cd2 to 035b992 Compare December 10, 2024 15:44
* better ui for outdated tag
* refactored TitleBarTags to not pass the singleton in its attribs
@silentrald silentrald force-pushed the bugfix/disable-linux-auto-update branch from 035b992 to 0b28cd6 Compare December 10, 2024 15:47
@Zagrios
Copy link
Owner

Zagrios commented Dec 10, 2024

Thanks @silentrald 🙌
Merging 🚀

@Zagrios Zagrios merged commit 0f5ea88 into Zagrios:master Dec 10, 2024
5 checks passed
@silentrald silentrald deleted the bugfix/disable-linux-auto-update branch December 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants