test: add a test where bbox is null

Zagrios · May 12, 2022 · c4845d7 · c4845d7
1 parent 298b87b
commit c4845d7
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 10 deletions.
diff --git a/__test__/index.spec.ts b/__test__/index.spec.ts
@@ -340,6 +340,13 @@ test('should get svg bbox(rect)', async (t) => {
   t.is(result.getHeight(), 100)
 })
 
+test('should bbox value is null', (t) => {
+  const svg = `<svg width="300px" height="300px" viewBox="0 0 300 300" version="1.1" xmlns="http://www.w3.org/2000/svg"></svg>`
+  const resvg = new Resvg(svg)
+  t.is(resvg.getBBox(), null)
+  t.is(resvg.innerBBox(), null)
+})
+
 test('should throw because invalid SVG attribute (width attribute is 0)', (t) => {
   const error = t.throws(
     () => {

diff --git a/__test__/wasm.spec.ts b/__test__/wasm.spec.ts
@@ -230,6 +230,13 @@ test('should get svg bbox(rect)', async (t) => {
   t.is(result.getHeight(), 100)
 })
 
+test('should bbox value is null', (t) => {
+  const svg = `<svg width="300px" height="300px" viewBox="0 0 300 300" version="1.1" xmlns="http://www.w3.org/2000/svg"></svg>`
+  const resvg = new Resvg(svg)
+  t.is(resvg.getBBox(), null)
+  t.is(resvg.innerBBox(), null)
+})
+
 // throws
 test('should throw because invalid SVG (blank string)', (t) => {
   const error = t.throws(

diff --git a/example/bbox.js b/example/bbox.js
@@ -23,7 +23,7 @@ async function main() {
 
   // const bbox = resvg.innerBBox()
   const bbox = resvg.getBBox()
-  resvg.cropByBBox(bbox)
+  if (bbox) resvg.cropByBBox(bbox)
   const pngData = resvg.render()
   const pngBuffer = pngData.asPng()
 

diff --git a/js-binding.d.ts b/js-binding.d.ts
@@ -21,13 +21,13 @@ export class Resvg {
    *
    * Note: path bounding box are approx values.
    */
-  innerBBox(): BBox
+  innerBBox(): BBox | null
   /**
    * Calculate a maximum bounding box of all visible elements in this SVG.
    * This will first apply transform.
    * Similar to `SVGGraphicsElement.getBBox()` DOM API.
    */
-  getBBox(): BBox
+  getBBox(): BBox | null
   /**
    * Use a given `BBox` to crop the svg. Currently this method simply changes
    * the viewbox/size of the svg and do not move the elements for simplicity

diff --git a/wasm/index.html b/wasm/index.html
@@ -181,13 +181,11 @@
         const resvgJS = new resvg.Resvg(svg, opts)
         document.querySelector('#svg-info').textContent = 'Original SVG size: ' + resvgJS.width + ' x ' + resvgJS.height + ' px'
 
-        const bbox = resvgJS.innerBBox()
-        const bbox2 = resvgJS.getBBox()
-        console.log('SVG innerBBox', bbox)
-        console.log('SVG getBBox', bbox2)
-        if (hasCrop) {
-          resvgJS.cropByBBox(bbox2)
-        }
+        const innerBBox = resvgJS.innerBBox()
+        const bbox = resvgJS.getBBox()
+        console.log('SVG innerBBox', innerBBox)
+        console.log('SVG getBBox', bbox)
+        if (hasCrop && bbox) resvgJS.cropByBBox(bbox)
         const pngData = resvgJS.render()
         const pngBuffer = pngData.asPng()