[experiment] add SourceLink to the Fable.Remoting.Json nuget package #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #262 and thought that as I've been having a go with Remoting recently and SourceLink might be useful, Id have a go at doing the change.
It's labelled 'experiment' because I've never done it on a project using Paket before - I gather from reading elsewhere that the 'copy_local: true' is the way to make it attach SourceLink to the build, but to not make the produced Remoting package have a runtime dependency on the SourceLink packages. So - I wanted to confirm that is ok before doing any of the other packages.
This is what the before (the current package published to nuget.org on the left) and after (a local package build on the right):
So the repository information is there.
Note: This is using the SourceLink approach of putting the pdb files in the nupkg - an alternative is to make a snupkg file, but I haven't actually done that before, and don't know what the publishing procedure is.
Related note: There are warnings in the package build about
PackageLicenseUrl
being deprecated - any thoughts or objections for a PR to replace it withPackageLicenseExpression
?