New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Markdown link (a) component #622

Open

tboby wants to merge 2 commits into Zaid-Ajaj:master from tboby:patch-1

tboby commented Sep 15, 2024

This confused me for a while as I thought I was using components wrong!

 Markdown.markdown [
      markdown.children rel.Description
      markdown.components [
          unbox<IComponent> (
              Interop.mkAttr "a" (fun (x: ILinkProperties) ->
                  Html.a [
                      prop.children x.children
                      prop.className "link"
                      prop.href x.href
                  ])
          )
      ]
  ]

works, which I assume is what linkReference is supposed to be overriding.

The table at https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15 implies that trow/tcell may be wrong too, but I didn't check that.

tboby added 2 commits

September 15, 2024 15:03


          Fix link (a) component

1ada8f7


          Remove newline

66e4e5d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet