Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 1 "Understanding Fable" updates for Fable v4 #176

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zaid-Ajaj
Copy link
Owner

Requires PR fable-getting-started#31 to be merged first.

This PR updates the first chapter to use an updated fable-getting-started template using Fable v4 being pulled from dotnet tools and using simplified webpack setup

cc @MangelMaxime @alfonsogarciacaro it would be amazing if you could glance over the content to see if it is all good

@MangelMaxime
Copy link
Collaborator

I didn't run the project but I think the explanations are correct.

If I remember correctly how --runFast works, the first time that the user will run npm run watch on a clean project he will have to wait for the initial compilation even if webpack is started because not compiled files will exist yet. I think webpack will report an error message (in red).

So I don't know if you prefer to use --run so start webpack only when the first compilation of Fable is done.

I am mentioning that only in case you want to avoid a new user to have a red message printed on its first run.


I think I would probably add the content of package.json (just the interesting sections) in the documentation directly because, when reading the page I was looking at what npm run start does. Because, npm run start by itself can do anything.

@HarryMcCarney
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants