Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Edit entries #36

Merged
merged 52 commits into from
Dec 3, 2023
Merged

Feature: Edit entries #36

merged 52 commits into from
Dec 3, 2023

Conversation

Zaphoood
Copy link
Owner

@Zaphoood Zaphoood commented Dec 3, 2023

This PR introduces the following ways of editing entries:

  • Deleting existing fields
  • Changing the value of existing entry fields
  • Undo/redo history

A few things are left to do, for example:

  • Renaming groups
  • Setting the 'last modified' value when editing entries
  • Adding new fields to entries

Every time the selector table is updated, store the current selected
item in the table of last remembered cursors. This allows us to always
update the cursor from that table when reloading the tables' contents.
This way, the bug is fixed where the left table's cursor wouldn't update
when focusing an item after an undo/redo.
This message was previously ignored, since Navigate only passes messages
to commandLine if it is focused; however, its status should also change
if it is not focues. This was fixed by instead handling the respective
message in Navigate itself
@Zaphoood Zaphoood merged commit 664f6c2 into master Dec 3, 2023
1 check passed
@Zaphoood Zaphoood deleted the feat/edit-entries branch December 3, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant