fix: init cache earlier to prevent infinite loop (#252)

src/cache/cache-on-interval.service.ts

@@ -69,22 +69,34 @@ export class CacheOnIntervalService implements OnModuleInit, OnModuleDestroy {
     const cacheManager = this.cacheManager;
 
     // Augment the method to be cached with caching mechanism
-    instance[methodName] = async function (...args: any[]) {
+    instance[methodName] = async function () {
       const cachedValue = await cacheManager.get(cacheKey);
 
       if (cachedValue) {
         return cachedValue;
       } else {
-        try {
-          const liveData = await methodRef.apply(instance, args);
-          await cacheManager.set(cacheKey, liveData, { ttl });
-          return liveData;
-        } catch (e) {
-          logger.error(`@CacheOnInterval error for ${instance.constructor.name}#${methodName}`, e);
-        }
+        logger.warn(
+          `@CacheOnInterval has no cache primed for ${instance.constructor.name}#${methodName}. Please wait for a few seconds as the cache is primed.`,
+        );
       }
     };
 
+    let liveData = methodRef.apply(instance);
+    // Duck typing shennanigans
+    if (!liveData.then) {
+      liveData = new Promise(liveData);
+    }
+    liveData
+      .then(d => {
+        return cacheManager.set(cacheKey, d, { ttl });
+      })
+      .then(() => {
+        logger.log(`Cache ready for for ${instance.constructor.name}#${methodName}`);
+      })
+      .catch(e => {
+        logger.error(`@CacheOnInterval error init for ${instance.constructor.name}#${methodName}`, e);
+      });
+
     // Save the interval
     const interval = setInterval(async () => {
       try {