-
Notifications
You must be signed in to change notification settings - Fork 381
feat(diffusion-protocol): Diff integration (#2) #629
Conversation
* started diff integation * added links token and color * added keywords * added groups * color change * description
* started diff integation * added links token and color * added keywords * added groups * color change * description * integrate diffusion
Hey @scruffy-dev ! Thanks for contributing. You'll likely find this recipe quite useful for integrating pools, this one for your farms, and this one for xDIFF. Glad to discuss further in Discord! |
very cool, the only issue is that the get position requires the graph which is not yet supported on evmos. Can we merge this in as is and then I can add the recipes when all dependencies are supported |
@scruffy-dev Sure that shouldn't be a problem. You can also rely on the resolvePoolTokenAddresses: this.uniswapV2OnChainPoolTokenAddressStrategy.build({
resolvePoolsLength: ({ multicall, factoryContract }) => multicall.wrap(factoryContract).allPairsLength(),
resolvePoolAddress: ({ multicall, factoryContract, poolIndex }) =>
multicall.wrap(factoryContract).allPairs(poolIndex),
}), This will resolve 301 pairs currently. Let me know if you want to go forward with this for the time being; otherwise, we can merge this in its current state. |
* started diff integation * added links token and color * added keywords * added groups * color change * description * integrate diffusion * added token fetcher
hey thanks for the heads up, I was able to add the token fetcher, will circle back to the master chef when I get more time next week, If is cool and this PR works I am ok with merging it now and creating a separate PR. |
@scruffy-dev Looks good to me. The balances will work by default, so we can get this merged now and circle back for the master chef later. |
Hello @scruffy-dev ! Looks like you did not provide an address when submitting your PR. I recognize it may have seemed kind of random that we were asking for a wallet address with a PR submission, but we are actually looking for ways to reward Studio contributors in the future. Is there an address you’d want to provide? Could even be an empty address, if you do not have an doxxed address Let me know! Also, if you’d like to privately provide it, feel free to shoot me a TG https://t.me/SamIAm_0x or DM on the Zapper Discord. Thanks! |
Gentle ping on this @scruffy-dev ! This is a real message from a person at Zapper! |
Description
Added diffusion to studio. Btw awesome CLI tool real easy to use thank you
Checklist