Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(diffusion-protocol): Diff integration (#2) #629

Merged
merged 6 commits into from Jun 15, 2022
Merged

feat(diffusion-protocol): Diff integration (#2) #629

merged 6 commits into from Jun 15, 2022

Conversation

scruffy-dev
Copy link
Contributor

@scruffy-dev scruffy-dev commented Jun 11, 2022

Description

Added diffusion to studio. Btw awesome CLI tool real easy to use thank you

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

* started diff integation

* added links token and color

* added keywords

* added groups

* color change

* description
@scruffy-dev scruffy-dev changed the title diffusion integation (#1) feat(diffusion-protocol): diffusion integration (#1) Jun 11, 2022
@scruffy-dev scruffy-dev changed the title feat(diffusion-protocol): diffusion integration (#1) feat(diffusion-protocol): started diff integration (#1) Jun 11, 2022
* started diff integation

* added links token and color

* added keywords

* added groups

* color change

* description

* integrate diffusion
@scruffy-dev scruffy-dev changed the title feat(diffusion-protocol): started diff integration (#1) feat(diffusion-protocol): Diff integration (#2) Jun 11, 2022
@immasandwich
Copy link
Contributor

Hey @scruffy-dev ! Thanks for contributing. You'll likely find this recipe quite useful for integrating pools, this one for your farms, and this one for xDIFF.

Glad to discuss further in Discord!

@scruffy-dev
Copy link
Contributor Author

very cool, the only issue is that the get position requires the graph which is not yet supported on evmos. Can we merge this in as is and then I can add the recipes when all dependencies are supported

@immasandwich
Copy link
Contributor

immasandwich commented Jun 14, 2022

@scruffy-dev Sure that shouldn't be a problem. You can also rely on the UniswapV2OnChainPoolTokenAddressStrategy described here to retrieve pool addresses from the factory contract (rather than TheGraph), pointing to 0x6aBdDa34Fb225be4610a2d153845e09429523Cd2 as your factory contract.

resolvePoolTokenAddresses: this.uniswapV2OnChainPoolTokenAddressStrategy.build({
  resolvePoolsLength: ({ multicall, factoryContract }) => multicall.wrap(factoryContract).allPairsLength(),
  resolvePoolAddress: ({ multicall, factoryContract, poolIndex }) =>
    multicall.wrap(factoryContract).allPairs(poolIndex),
  }),

This will resolve 301 pairs currently. Let me know if you want to go forward with this for the time being; otherwise, we can merge this in its current state.

* started diff integation

* added links token and color

* added keywords

* added groups

* color change

* description

* integrate diffusion

* added token fetcher
@scruffy-dev
Copy link
Contributor Author

hey thanks for the heads up, I was able to add the token fetcher, will circle back to the master chef when I get more time next week, If is cool and this PR works I am ok with merging it now and creating a separate PR.

@immasandwich
Copy link
Contributor

@scruffy-dev Looks good to me. The balances will work by default, so we can get this merged now and circle back for the master chef later.

@immasandwich immasandwich merged commit fac4d88 into Zapper-fi:main Jun 15, 2022
@SamIam-0x
Copy link
Contributor

Hello @scruffy-dev !

Looks like you did not provide an address when submitting your PR. I recognize it may have seemed kind of random that we were asking for a wallet address with a PR submission, but we are actually looking for ways to reward Studio contributors in the future.

Is there an address you’d want to provide? Could even be an empty address, if you do not have an doxxed address

Let me know! Also, if you’d like to privately provide it, feel free to shoot me a TG https://t.me/SamIAm_0x or DM on the Zapper Discord.

Thanks!
Sam

@SamIam-0x
Copy link
Contributor

Gentle ping on this @scruffy-dev ! This is a real message from a person at Zapper!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants