Allow HTTP client specification for ListenBrainz
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the constructors to match the approach taken by the `Query` class of the MusicBrainz library. Either you use the constructor where you pass a client (in which case you are responsible for setting whatever default user agent you want), or you use one of the other a constructors to set up the user agent values to use with the internally-created client(s). The `[Default]ContactInfo` and `[Default]ProductInfo` properties have been dropped in favour of a `[Default]UserAgent` property (a list of product info header values). There are also two additional methods, `ConfigureClient` and `ConfigureClientCreation`, which allow exercising some control over clients created on-demand by the class.
`ListenBrainz.Internals.cs` contains all the internals, `ListenBrainz.EndPoints.cs` contains the public API for the various API endpoints, and `ListenBrainz.cs` contains the constructors, properties and `HttpClient`/`IDispose` handling.
Zastai
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the constructors to match the approach taken by the
Queryclass of the MusicBrainz library. Either you use the constructor where you pass a client (in which case you are responsible for setting whatever default user agent you want), or you use one of the other a constructors to set up the user agent values to use with the internally-created client(s).The
[Default]ContactInfoand[Default]ProductInfoproperties have been dropped in favour of a[Default]UserAgentproperty (a list of product info header values).There are also two additional methods,
ConfigureClientandConfigureClientCreation, which allow exercising some control over clients created on-demand by the class.In addition,
ListenBrainz.cshas been split into multiple parts:ListenBrainz.Internals.cscontains all the internals,ListenBrainz.EndPoints.cscontains the public API for the various API endpoints, andListenBrainz.cscontains the constructors, properties andHttpClient/IDisposehandling.