Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to JSR #85

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Publish to JSR #85

merged 4 commits into from
Jul 29, 2024

Conversation

emrahcom
Copy link
Contributor

This PR adds a Github workflow to publish to JSR.

Assumed that the scope will be @zaubrik/djwt on JSR registry. Please update it (in deno.json) if it will be something else and update the version as 3.0.2 after the initial test.

To complete the task, @zaubrik/djwt should be created on jsr.io and linked to this repository.

@hansSchall
Copy link

I would love this and as far as i can see, djwt only depends on base64url from deno std, so it should be possible to use this even in browser.

@timonson timonson merged commit 1cb4a8a into Zaubrik:master Jul 29, 2024
@timonson
Copy link
Member

Thank you @emrahcom

@timonson
Copy link
Member

timonson commented Jul 29, 2024

@emrahcom something went wrong with CI. Would you mind taking a look into it?

https://github.com/Zaubrik/djwt/actions/runs/10150942921/job/28069171066

error: Import 'https://registry-staging.deno.com/@std/encoding/meta.json' failed: error sending request for url (https://registry-staging.deno.com/@std/encoding/meta.json): error trying to connect: dns error: failed to lookup address information: nodename nor servname provided, or not known
at file:///Users/runner/work/djwt/djwt/deps.ts:4:8

@emrahcom emrahcom deleted the feat-jsr-publish branch July 30, 2024 07:15
@hansSchall
Copy link

This is my default JSR CI workflow (might help): https://github.com/deno-plc/slip/blob/main/.github/workflows/jsr.yml

A few weeks ago I have built a JSR plugin for Vite and from that work I know that the JSR package resolution never fetches anything from registry-staging.deno.com, if the was jsr.io it would fetch all published versions, which is the first step when resolving imports. It looks like the problem is the old deno version (1.37.2), maybe in those days JSR was experimental and fetched from another domain that is shut down now.

By the way, I understand why the CI checks stable and canary, but why old and why OS matrix, djwt does not rely on anything patform dependent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants