Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate if timeout has been defined before using the same. #2

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix: Validate if timeout has been defined before using the same. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbclient/SecretsClient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def import_all_secrets(self, log_dir='secret_scopes/', secret_scopes: list = [],
else:
logging.info("Skipping ACL Updates for {}".format(scope_name))
# loop through the scope and create the k/v pairs
with open(file_path, 'r', encoding="utf-8") as fp:
with open(file_path, 'r', encoding="utf-8") as fp:
for s in fp:
s_dict = json.loads(s)
k = s_dict.get('name')
Expand Down
4 changes: 2 additions & 2 deletions dbclient/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ def build_client_config(profile, url, token, args):
'skip_failed': args.skip_failed,
'debug': args.debug,
'file_format': str(args.notebook_format),
'timeout':args.timeout,
'skip_missing_users':args.skip_missing_users
'timeout':args.timeout if 'timeout' in args else 86400,
'skip_missing_users':args.skip_missing_users if 'skip_missing_users' in args else True
}
# this option only exists during imports so we check for existence
if 'overwrite_notebooks' in args:
Expand Down