Add no_std support
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dconnolly hi, any updates? |
|
Hi @dconnolly, we would really appreciate this being merged, let us know if we can help. Thanks. |
We can spend some time with this PR to get it merged this coming week I think 👍 |
conradoplg
approved these changes
May 4, 2022
There was a problem hiding this comment.
Looks great, thanks!
I've confirmed that:
- no_std is not enabled by default
- everything compiles with no_std, including dependencies. I did that by running
rustup target add thumbv6m-none-eabi
cargo build --no-default-features --target thumbv6m-none-eabi
Since that target does not support std. (I tried cargo nono but it seemed to think curve29919-dalek used std when it didn't.)
@dconnolly can you take a quick look and merge if it's OK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
no_stdsupport toed25519-zebraand keeps all thestdrelated bits under a feature with the same name.