Skip to content

Commit

Permalink
Improve comment inside crawl_and_dial
Browse files Browse the repository at this point in the history
Describe an edge case that is also handled but was not explicit.

Co-authored-by: teor <teor@riseup.net>
  • Loading branch information
jvff and teor2345 committed Dec 9, 2021
1 parent 3002239 commit cb0f2ee
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions zebra-network/src/peer_set/initialize.rs
Original file line number Diff line number Diff line change
Expand Up @@ -714,8 +714,8 @@ where
}
HandshakeConnected { address, client } => {
debug!(candidate.addr = ?address, "successfully dialed new peer");
// successes are handled by an independent task, so they
// shouldn't hang
// successes are handled by an independent task, except for `candidates.update` in
// this task, which has a timeout, so they shouldn't hang
peerset_tx.send(Ok((address, client))).await?;
}
HandshakeFailed { failed_addr } => {
Expand Down

0 comments on commit cb0f2ee

Please sign in to comment.