Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send inbound AdvertiseTransactionIds broadcasts to the mempool download & verify stream #1081

Closed
hdevalence opened this issue Sep 20, 2020 · 5 comments
Closed

Send inbound AdvertiseTransactionIds broadcasts to the mempool download & verify stream #1081

hdevalence opened this issue Sep 20, 2020 · 5 comments
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Sep 20, 2020 •
edited by teor2345
Loading

Is your feature request related to a problem? Please describe.

The inbound network service should handle AdvertiseTransactionIds requests correctly.

Describe the solution you'd like

We need to send advertised transaction IDs to the mempool download and verify service.

Additional context

Part of #889.
@hdevalence hdevalence added A-rust Area: Updates to Rust code S-blocked Status: Blocked on other tasks C-enhancement Category: This is an improvement labels Sep 20, 2020
@hdevalence hdevalence mentioned this issue Sep 20, 2020
Closed
11 tasks
@teor2345 teor2345 added this to the Sync and Network milestone Sep 29, 2020
@mpguerra mpguerra removed this from the Sync and Network milestone Jan 5, 2021
@mpguerra mpguerra added this to the 2021 Sprint 16 milestone Aug 9, 2021
@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Aug 9, 2021
@dconnolly dconnolly removed this from the 2021 Sprint 16 milestone Aug 9, 2021
@teor2345 teor2345 changed the title Handle AdvertiseTransaction in the Inbound service. Download AdvertiseTransactionIds in the mempool download & verify stream Aug 17, 2021
@teor2345 teor2345 mentioned this issue Aug 17, 2021
Closed
59 tasks
@teor2345 teor2345 changed the title Download AdvertiseTransactionIds in the mempool download & verify stream Send AdvertiseTransactionIds to the mempool download & verify stream Aug 17, 2021
@teor2345 teor2345 changed the title Send AdvertiseTransactionIds to the mempool download & verify stream Send inbound AdvertiseTransactionIds to the mempool download & verify stream Aug 17, 2021
@teor2345 teor2345 changed the title Send inbound AdvertiseTransactionIds to the mempool download & verify stream Send inbound AdvertiseTransactionIds broadcasts to the mempool download & verify stream Aug 17, 2021
@mpguerra mpguerra added this to the 2021 Sprint 18 milestone Aug 26, 2021
@conradoplg
Copy link
Collaborator

This may be the same as #2637

@conradoplg
Copy link
Collaborator

This may be the same as #2637

Pinging @mpguerra about the duplicate

@mpguerra
Copy link
Contributor

mpguerra commented Sep 8, 2021

Yup, it looks like it is the same @dconnolly can you confirm and we can close this one as the duplicate

@mpguerra mpguerra removed this from the 2021 Sprint 18 milestone Sep 8, 2021
@mpguerra
Copy link
Contributor

mpguerra commented Sep 8, 2021

@conradoplg are there any other inbound requests other than AdvertiseTransactionIds that are implemented in #2637 ?

@mpguerra
Copy link
Contributor

mpguerra commented Sep 9, 2021

closed by #2679

@mpguerra mpguerra closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@conradoplg @hdevalence @dconnolly @mpguerra @teor2345 @oxarbitrage