Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download mempool-bound transactions, log their transaction::Verifier results to stdout prior to mempool storage #2637

Closed
Tracked by #2309
mpguerra opened this issue Aug 16, 2021 · 4 comments · Fixed by #2679
Assignees

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Aug 16, 2021

We can take our block syncer and copy/paste that into a transaction downloader stream, and for a first pass, make sure that all the transcations we download pass the TransactionVerifier, and log the result to stdout.

Later, those passing transactions will be inserted into our mempool via a call to the MempoolService

@mpguerra mpguerra mentioned this issue Aug 16, 2021
59 tasks
@mpguerra mpguerra added this to the 2021 Sprint 17 milestone Aug 16, 2021
@dconnolly dconnolly changed the title Run mempool-bound transactions through Transaction verifier prior to mempool storage Download mempool-bound transactions, log their transaction::Verifier results to stdout prior to mempool storage Aug 16, 2021
@teor2345

This comment has been minimized.

@teor2345
Copy link
Contributor

We'll need to remove this unimplemented! panic as part of this ticket:

if is_mempool {
// XXX determine exactly which rules apply to mempool transactions
unimplemented!("Zebra does not yet have a mempool (#2309)");
}

@teor2345
Copy link
Contributor

We can also just verify PushTransactions, but I'm not sure how common they are.

I just checked using Grafana (#2673), and I didn't see any PushTransaction messages sent by peers.
So we'll have to download transactions before we can verify them.

@teor2345
Copy link
Contributor

We still need to handle PushTransaction, we just can't test using it, because it almost never happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants