Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ZIP-215: Ed25519 Validation Rules #1565

Closed
dconnolly opened this issue Jan 7, 2021 · 1 comment · Fixed by #1811
Closed

Enable ZIP-215: Ed25519 Validation Rules #1565

dconnolly opened this issue Jan 7, 2021 · 1 comment · Fixed by #1811
Assignees
Labels
A-consensus Area: Consensus rule updates NU-4 Canopy Network Upgrade: Canopy specific tasks
Milestone

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Jan 7, 2021

Solution

We need to upgrade our version of ed25519-zebra to use the validation rules in ZIP-215 and actually validate the Sprout Ed25519 signatures for full Sprout validation.

https://zips.z.cash/zip-0215

This involves pulling in the latest version of ed25519-zebra, checking that our async Verifier is well tested against the new rules, and making sure this validation is done by default on all blocks.

Alternatives

We could just use the new rules on blockheight >= Canopy, but that complicates our code.

@dconnolly dconnolly added the NU-4 Canopy Network Upgrade: Canopy specific tasks label Jan 7, 2021
@dconnolly dconnolly self-assigned this Jan 7, 2021
@dconnolly dconnolly added the A-consensus Area: Consensus rule updates label Jan 7, 2021
@mpguerra mpguerra added this to the 2021 Sprint 4 milestone Feb 22, 2021
@teor2345
Copy link
Contributor

We can just use the new rules for all blocks (including pre-Canopy blocks), because the new rules allow all valid old signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates NU-4 Canopy Network Upgrade: Canopy specific tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants