Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to the post-Canopy ed25519 signature rules #1667

Closed
teor2345 opened this issue Feb 3, 2021 · 4 comments · Fixed by #1811
Closed

Move to the post-Canopy ed25519 signature rules #1667

teor2345 opened this issue Feb 3, 2021 · 4 comments · Fixed by #1811
Assignees
Labels
A-consensus Area: Consensus rule updates A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup NU-4 Canopy Network Upgrade: Canopy specific tasks
Milestone

Comments

@teor2345
Copy link
Contributor

teor2345 commented Feb 3, 2021

Is your feature request related to a problem? Please describe.

Zcash uses a different set of ed25519 signature verification rules after the Canopy network upgrade.

Valid signatures under the new rules are a superset of those under the old rules, so we can just use the new rules for all signatures: all [Ed25519] signatures that validated under the old rules will validate under the new rules, and there are no new signatures, so you can just retcon all the old signatures as being under the new rules.

Describe the solution you'd like

Update to ed25519-zebra 2.0 or later.

Describe alternatives you've considered

This is a required protocol change.

We could verify old signatures under the old rules, and new signatures under the new rules, but that complicates our dependencies.

We could checkpoint on Canopy, but that complicates our code.

Additional context

ed25519-zebra explanation: https://github.com/ZcashFoundation/ed25519-zebra#zip-215-and-changes-to-zcash-flavored-ed25519
ZIP-215: https://github.com/zcash/zips/blob/master/zip-0215.rst

@teor2345 teor2345 added A-dependencies Area: Dependency file updates A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU-4 Canopy Network Upgrade: Canopy specific tasks C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage C-deprecation Category: Old features that will soon be gone P-Medium labels Feb 3, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Feb 3, 2021

This ticket could be medium or large, depending on what we decide to do.

@str4d
Copy link
Contributor

str4d commented Feb 3, 2021

You can also decide to continue to verify pre-Canopy signatures for implementation simplicity, but using the post-Canopy rules (which are more expansive).

@teor2345 teor2345 changed the title Decide how we want to checkpoint on Canopy Move to the post-Canopy ed25519 signature rules Feb 3, 2021
@teor2345 teor2345 removed C-deprecation Category: Old features that will soon be gone C-enhancement Category: This is an improvement labels Feb 3, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Feb 3, 2021

Thanks I've edited the ticket.

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 18, 2021
@mpguerra mpguerra added this to the 2021 Sprint 4 milestone Feb 22, 2021
@dconnolly
Copy link
Contributor

Depends on #1565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-dependencies Area: Dependency file updates A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup NU-4 Canopy Network Upgrade: Canopy specific tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants