-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a timeout to DNS seeder requests to avoid hangs #1613
Milestone
Comments
teor2345
added
C-bug
Category: This is a bug
A-rust
Area: Updates to Rust code
S-needs-triage
Status: A bug report needs triage
labels
Jan 22, 2021
Tentatively adding this task to Sprint 2, because:
|
I increased the estimate here, because we've added some possible acceptance tests changes. |
teor2345
added
P-High
and removed
S-needs-triage
Status: A bug report needs triage
labels
Jan 28, 2021
This was referenced Feb 1, 2021
6 tasks
teor2345
added a commit
to teor2345/zebra
that referenced
this issue
Feb 19, 2021
We disabled these tests pending ZcashFoundation#1613. But the comment incorrectly said we were waiting for ZcashFoundation#1631.
2 tasks
teor2345
added a commit
to teor2345/zebra
that referenced
this issue
Feb 19, 2021
We disabled these tests pending ZcashFoundation#1613. But the comment incorrectly said we were waiting for ZcashFoundation#1631.
teor2345
added a commit
to teor2345/zebra
that referenced
this issue
Feb 19, 2021
We disabled these tests pending ZcashFoundation#1613. But the comment incorrectly said we were waiting for ZcashFoundation#1631.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
When zebrad launches, it asks some DNS seeders for a list of initial peers. But if DNS or the seeder is slow or down, zebrad can hang without any output.
We've observed these hangs in our CI, but we don't know if it's just one seeder that's having issues. If it is, this fix could make our CI more reliable.
Describe the solution you'd like
We don't panic on any of these errors, because they are recoverable - zebrad can discover peers from inbound connections, if its address is distributed by a DNS seeder (or manually).
Describe alternatives you've considered
Do nothing - zebrad will hang if there are DNS issues
Panic - these errors are recoverable, and "no initial peers" is a valid config
Additional context
We discovered this issue while troubleshooting bind hangs in #1535
The text was updated successfully, but these errors were encountered: