Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Spend and Output async groth verifiers with transaction verifier #1645

Closed
10 tasks
yaahc opened this issue Jan 27, 2021 · 1 comment · Fixed by #1713
Closed
10 tasks

Integrate Spend and Output async groth verifiers with transaction verifier #1645

yaahc opened this issue Jan 27, 2021 · 1 comment · Fixed by #1713
Assignees
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-1 Sapling Network Upgrade: Sapling specific tasks
Milestone

Comments

@yaahc
Copy link
Contributor

yaahc commented Jan 27, 2021

In #830 we implement an async batching groth16 verification API on top of bellman's existing single groth proof verification functions. This verifier now needs to be integrated with the rest of the system and fully tested.

Todo

These tasks should be split into 2 - 3 PRs.

Follow up:

#1835

@yaahc yaahc added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jan 27, 2021
@yaahc yaahc self-assigned this Jan 27, 2021
@yaahc yaahc added this to the 2021 Sprint 2 milestone Jan 27, 2021
@dconnolly dconnolly added A-rust Area: Updates to Rust code NU-1 Sapling Network Upgrade: Sapling specific tasks A-consensus Area: Consensus rule updates labels Jan 27, 2021
@dconnolly
Copy link
Contributor

dconnolly commented Feb 1, 2021

Dependent on #1287 to fully verify the Spend's and Output's and JoinSplit's on chain.

EDIT: strike that, 1287 is required to validate the 'anchor has been seen before' consensus rule, but that is not strictly a requirement to verify the Groth16 proofs themselves

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 2, 2021
@dconnolly dconnolly self-assigned this Feb 5, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 2, 2021 Sprint 3 Feb 8, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 3, 2021 Sprint 4 Feb 26, 2021
@dconnolly dconnolly changed the title Integrate async groth verifier with transaction verifier Integrate Spend and Output async groth verifiers with transaction verifier Mar 2, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 4, 2021 Sprint 5 Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-1 Sapling Network Upgrade: Sapling specific tasks
Projects
None yet
3 participants