Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement incremental, sparse note commitment trees for Sapling and Orchard #1287

Closed
2 tasks done
dconnolly opened this issue Nov 12, 2020 · 5 comments
Closed
2 tasks done
Assignees
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) NU-1 Sapling Network Upgrade: Sapling specific tasks NU-5 Network Upgrade: NU5 specific tasks

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Nov 12, 2020

Implement the note commitment trees in order to compute anchors, for

  • Sapling
  • Orchard

In that order.

The follow-on to #286

Pertains to #983 , #958

Follow ups:

@dconnolly dconnolly added A-consensus Area: Consensus rule updates NU-1 Sapling Network Upgrade: Sapling specific tasks NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) A-rust Area: Updates to Rust code labels Nov 12, 2020
@dconnolly dconnolly added this to the First Alpha Release milestone Nov 12, 2020
@dconnolly dconnolly self-assigned this Nov 12, 2020
@teor2345 teor2345 added the S-needs-triage Status: A bug report needs triage label Dec 14, 2020
@mpguerra mpguerra removed this from the v1.0.0-alpha.1 milestone Jan 11, 2021
@mpguerra mpguerra reopened this Jan 11, 2021
@dconnolly dconnolly removed the S-needs-triage Status: A bug report needs triage label Jan 11, 2021
@dconnolly dconnolly added this to the 2021 Sprint 1 milestone Jan 11, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 1, 2021 Sprint 2 Jan 25, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 2, 2021 Sprint 3 Feb 8, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 3, 2021 Sprint 4 Feb 22, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 4, 2021 Sprint 5 Mar 8, 2021
@mpguerra mpguerra changed the title Implement incremental, sparse note commitment trees for Sapling and Sprout Implement incremental, sparse note commitment trees for Sapling, Sprout and Orchard Mar 15, 2021
@mpguerra mpguerra modified the milestones: 2021 Sprint 5, 2021 Sprint 6 Mar 17, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 6 milestone Apr 6, 2021
@teor2345 teor2345 added this to the 2021 Sprint 9 milestone May 3, 2021
@teor2345
Copy link
Contributor

teor2345 commented May 6, 2021

@dconnolly hey did you want to split this work into separate tickets or PRs for sprout, sapling, and orchard?

@mpguerra mpguerra linked a pull request Jun 14, 2021 that will close this issue
1 task
@teor2345 teor2345 removed a link to a pull request Jun 14, 2021
1 task
@mpguerra mpguerra changed the title Implement incremental, sparse note commitment trees for Sapling, Sprout and Orchard Implement incremental, sparse note commitment trees for Sapling and Orchard Jul 12, 2021
@mpguerra
Copy link
Contributor

Since the sprout parts have now moved to #2484 can we consider this issue done now that #2407 has merged?

@teor2345
Copy link
Contributor

Since the sprout parts have now moved to #2484 can we consider this issue done now that #2407 has merged?

No, we still need to use these calculations in the state to finish #1287.
See #2407 (comment)

@conradoplg
Copy link
Collaborator

I've update the issue to restrict its scope to the trees themselves. We should be able to close this now.

@dconnolly
Copy link
Contributor Author

Resolved by #2458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) NU-1 Sapling Network Upgrade: Sapling specific tasks NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

No branches or pull requests

4 participants