Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sapling note commitment tree #286

Closed
dconnolly opened this issue Mar 3, 2020 · 6 comments · Fixed by #1045
Closed

Implement Sapling note commitment tree #286

dconnolly opened this issue Mar 3, 2020 · 6 comments · Fixed by #1045
Assignees
@dconnolly
Labels
C-design Category: Software design work NU-1 Sapling Network Upgrade: Sapling specific tasks S-needs-design Status: Needs a design decision
Milestone
Transaction Valid...

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Mar 3, 2020 •
edited by hdevalence
Loading

We need a note commitment tree implementation for both Sprout and Sapling, even when checkpointing on Sapling activation, because we need to accumulate the correct tree state up to Sapling activation in order to validate V4 Sprout-on-Groth16 proofs.

We may want to adapt the implementation in librustzcash to fit our needs.

Depends on #273

Related to #36 (Sprout note commitment tree)
@hdevalence hdevalence mentioned this issue Mar 3, 2020
Closed
@dconnolly dconnolly added the NU-1 Sapling Network Upgrade: Sapling specific tasks label Apr 2, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone May 28, 2020
@dconnolly
Copy link
Contributor Author

https://github.com/zcash/librustzcash/blob/37270776beb10acd34bdd96dc6a4bb44117cb00a/zcash_primitives/src/merkle_tree.rs

@yaahc
Copy link
Contributor

yaahc commented Jul 2, 2020

relevant discord conversation: https://discordapp.com/channels/676527656170160146/716086297210650634/728052748238585917

@dconnolly dconnolly self-assigned this Jul 2, 2020
@dconnolly
Copy link
Contributor Author

dconnolly commented Jul 2, 2020 •
edited
Loading

Depends on #330
Depends on #279

@dconnolly dconnolly added S-needs-design Status: Needs a design decision C-design Category: Software design work labels Jul 2, 2020
@yaahc yaahc self-assigned this Jul 2, 2020
This was referenced Jul 6, 2020
Closed
Merged
@dconnolly dconnolly mentioned this issue Jul 9, 2020
Closed
6 tasks
@yaahc yaahc removed their assignment Jul 21, 2020
@dconnolly dconnolly changed the title Design Sapling note commitment trees. design: Tree State in Rust, including Note Commitment Tree and its Nullifier Set Jul 30, 2020
@dconnolly
Copy link
Contributor Author

https://docs.rs/im/15.0.0/im/

@dconnolly dconnolly mentioned this issue Aug 11, 2020
Closed
27 tasks
@hdevalence hdevalence changed the title design: Tree State in Rust, including Note Commitment Tree and its Nullifier Set Note commitment trees Aug 11, 2020
@hdevalence
Copy link
Contributor

Edited title to distinguish from #289 for the nullifier set.

@hdevalence hdevalence changed the title Note commitment trees Sapling note commitment tree Aug 11, 2020
@hdevalence
Copy link
Contributor

Edited title to distinguish from #36

@dconnolly dconnolly changed the title Sapling note commitment tree Implement Sapling note commitment tree Sep 10, 2020
@dconnolly dconnolly mentioned this issue Sep 25, 2020
Merged
@dconnolly dconnolly mentioned this issue Nov 12, 2020
Closed
2 tasks
@dconnolly dconnolly mentioned this issue Mar 5, 2021
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
C-design Category: Software design work NU-1 Sapling Network Upgrade: Sapling specific tasks S-needs-design Status: Needs a design decision
Projects
None yet
Milestone
Transaction Validation
Development

Successfully merging a pull request may close this issue.

Sapling note commitment tree ZcashFoundation/zebra
3 participants
@hdevalence @dconnolly @yaahc