Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Sprout note commitment trees. #36

Closed
dconnolly opened this issue Sep 27, 2019 · 5 comments · Fixed by #1045
Closed

Design Sprout note commitment trees. #36

dconnolly opened this issue Sep 27, 2019 · 5 comments · Fixed by #1045
Assignees
@dconnolly
Labels
NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter)
Milestone
Transaction Valid...

Comments

@dconnolly
Copy link
Contributor

We may need a sprout note commitment tree, even if we checkpoint on sapling activation, in order to do sprout-on-groth16 proofs to move old sprout value.
@dconnolly dconnolly self-assigned this Sep 27, 2019
@dconnolly
Copy link
Contributor Author

Look at the one in librustzcash.

@hdevalence hdevalence changed the title Create SproutNoteCommitmentTree Design Sprout/Sapling note commitment trees. Dec 10, 2019
@hdevalence hdevalence mentioned this issue Dec 10, 2019
Closed
13 tasks
@hdevalence
Copy link
Contributor

Changed the title so that this can correspond to items in the list for #123.

@dconnolly
Copy link
Contributor Author

dconnolly commented Jan 16, 2020 •
edited
Loading

We may want to bring in the impl from librustzcash

https://github.com/zcash/librustzcash/blob/37270776beb10acd34bdd96dc6a4bb44117cb00a/zcash_primitives/src/merkle_tree.rs

@dconnolly dconnolly mentioned this issue Feb 13, 2020
Closed
@dconnolly dconnolly mentioned this issue Feb 25, 2020
Closed
@hdevalence
Copy link
Contributor

depends on #273 #274

@dconnolly dconnolly changed the title Design Sprout/Sapling note commitment trees. Design Sprout note commitment trees. Mar 3, 2020
@dconnolly dconnolly mentioned this issue Mar 3, 2020
Closed
@hdevalence hdevalence mentioned this issue Mar 3, 2020
Closed
@dconnolly dconnolly added the NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) label Apr 2, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone May 28, 2020
@dconnolly dconnolly removed this from the Validate transactions. milestone Jul 2, 2020
@dconnolly dconnolly mentioned this issue Aug 11, 2020
Closed
27 tasks
@dconnolly dconnolly added this to the Validate transactions. milestone Sep 9, 2020
@dconnolly
Copy link
Contributor Author

The 'design' part of this is basically contained in #983

@dconnolly dconnolly linked a pull request Sep 10, 2020 that will close this issue
Sapling note commitment tree #1045
Merged
@teor2345 teor2345 mentioned this issue Jan 4, 2021
Closed
@dconnolly dconnolly mentioned this issue Mar 5, 2021
Closed
53 tasks
dimxy pushed a commit to dimxy/komodo-zebra that referenced this issue Apr 5, 2023
@DeckerSU
Merge pull request ZcashFoundation#36 from KomodoPlatform/bugfix-peer…
33599a5 
…set-tests-after-merge

fix peer_set tests after getpeerinfo merge
skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
@skyl
start READMEs for backend local dev (ZcashFoundation#36)
4211da1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter)
Projects
None yet
Milestone
Transaction Validation
Development

Successfully merging a pull request may close this issue.

Sapling note commitment tree ZcashFoundation/zebra
2 participants
@hdevalence @dconnolly