Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sapling/Orchard note encryption implementation. #269

Closed
dconnolly opened this issue Feb 25, 2020 · 4 comments
Closed

Sapling/Orchard note encryption implementation. #269

dconnolly opened this issue Feb 25, 2020 · 4 comments
Labels
A-cryptography Area: Cryptography related C-design Category: Software design work NU-1 Sapling Network Upgrade: Sapling specific tasks

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Feb 25, 2020

We need an implementation of note encryption/decryption. This has possible overlap with librustzcash.

Two levels of completion:

All the types to represent in the transaction

Some types:

sapling::Note (plaintext)
sapling::OutCiphertext
sapling::EncryptedCiphertext

And implementing methods to do the note encryption

NoteEncryptionBuilder

But first:

note commitment trees: #36
addresses
as above, full Note implementation

Related: #181

Spec references:

https://zips.z.cash/protocol/protocol.pdf#saplingsend
https://zips.z.cash/protocol/protocol.pdf#orchardsend
https://zips.z.cash/protocol/protocol.pdf#saplingandorchardencrypt

Note that ZIP-212 is included in this ticket (it was incorporated into the spec)

@dconnolly dconnolly added Poll::Ready C-design Category: Software design work labels Feb 25, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone Feb 25, 2020
@dconnolly dconnolly added the NU-1 Sapling Network Upgrade: Sapling specific tasks label Apr 2, 2020
@dconnolly dconnolly removed this from the Validate transactions. milestone Jul 23, 2020
@teor2345
Copy link
Contributor

@dconnolly does this belong in the "Wallet Support" milestone, or the "Transaction Validation" milestone?

@dconnolly
Copy link
Contributor Author

Wallet support, otherwise we can't send money properly

@mpguerra
Copy link
Contributor

mpguerra commented Nov 2, 2021

Splitting the decryption part that we need for ZIP-212 into #3002

@mpguerra mpguerra removed this from the 2021 Sprint 22 milestone Nov 2, 2021
@mpguerra mpguerra changed the title Sapling note encryption/decryption implementation. Sapling note encryption implementation. Nov 2, 2021
@dconnolly dconnolly changed the title Sapling note encryption implementation. Sapling/Orchard note encryption implementation. May 26, 2022
@conradoplg conradoplg added the A-cryptography Area: Cryptography related label Jun 1, 2022
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
@teor2345
Copy link
Contributor

We're not planning to do full-node wallet work any time soon.

If we do, we'll need to decide if this ticket is in scope, and update its content, because the spec has changed since it was created.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
Repository owner moved this from 🆕 New to ✅ Done in Zebra Sep 29, 2022
@mpguerra mpguerra moved this from ✅ Done to 🛑 Won't Fix in Zebra Nov 9, 2022
skyl pushed a commit to skyl/zebra that referenced this issue Sep 25, 2024
Ashbury suggests we should make our terms more explicit and verbose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cryptography Area: Cryptography related C-design Category: Software design work NU-1 Sapling Network Upgrade: Sapling specific tasks
Projects
Archived in project
Development

No branches or pull requests

5 participants