Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EphemeralPrivateKey's for Orchard, Sapling, Sprout #2192

Closed
dconnolly opened this issue May 24, 2021 · 1 comment
Closed

Implement EphemeralPrivateKey's for Orchard, Sapling, Sprout #2192

dconnolly opened this issue May 24, 2021 · 1 comment
Labels
A-cryptography Area: Cryptography related A-rust Area: Updates to Rust code

Comments

@dconnolly
Copy link
Contributor

Is your feature request related to a problem? Please describe.
To send money, we need an EphemeralPrivateKey to go with our EphemeralPublicKeys that already exist in zebra-chain.

Describe the solution you'd like
Implement the newtype wrappers around pallas::Scalar, jubjub::Scalar, and I think x25519-dalek::SecretKey for Orchard, Sapling, and Sprout resepectively.

Describe alternatives you've considered
Use those types directly, which elides the specific use and capabilities of these keys vs the other uses of those generic types other places in our codebase.

Additional context
This must be done to complete #269

@dconnolly dconnolly added A-rust Area: Updates to Rust code P-Medium labels May 24, 2021
@mpguerra mpguerra added the S-needs-triage Status: A bug report needs triage label May 25, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jun 14, 2021
@conradoplg conradoplg added the A-cryptography Area: Cryptography related label Jun 1, 2022
@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@teor2345
Copy link
Contributor

We're not planning to do full-node wallet work any time soon.

If we do, we'll need to decide if this ticket is in scope.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2022
Repository owner moved this from 🆕 New to ✅ Done in Zebra Sep 28, 2022
@mpguerra mpguerra moved this from ✅ Done to 🛑 Won't Fix in Zebra Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cryptography Area: Cryptography related A-rust Area: Updates to Rust code
Projects
Archived in project
Development

No branches or pull requests

4 participants