Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes, commitments, nullifiers, etc #596

Merged
merged 69 commits into from
Aug 14, 2020
Merged

Notes, commitments, nullifiers, etc #596

merged 69 commits into from
Aug 14, 2020

Conversation

yaahc
Copy link
Contributor

@yaahc yaahc commented Jul 6, 2020 •
edited by dconnolly
Loading

Huge chunk of implementation work on Sprout and Sapling cryptography.

Closes #123
Closes #273
Closes #274
Closes #275
Closes #279
Closes #329
Closes #330
Closes #334

TODO:

@yaahc yaahc requested a review from a team July 6, 2020 20:16
@yaahc yaahc self-assigned this Jul 6, 2020
@yaahc

This comment has been minimized.

Sign in to view
@dconnolly dconnolly changed the title Start work implementing sprout note commitment function Notes, note commitments, note commitment trees, nullifiers Jul 9, 2020
@dconnolly dconnolly marked this pull request as draft July 9, 2020 17:42
@dconnolly dconnolly linked an issue Jul 9, 2020 that may be closed by this pull request
Type out Sprout and Sapling Notes #275
Closed
@dconnolly dconnolly mentioned this pull request Jul 9, 2020
Closed
6 tasks
@dconnolly dconnolly changed the title Notes, note commitments, note commitment trees, nullifiers [WIP] Notes, note commitments, note commitment trees, nullifiers Jul 14, 2020
This was linked to issues Jul 23, 2020
Pedersen Hash (at least for use in the Sapling merkle tree) #334
Closed
Implement Sapling note hashing functions #279
Closed
Finish refining all primitive types brought in by Transaction data. #123
Closed
@dconnolly dconnolly mentioned this pull request Jul 24, 2020
Merged
@ZcashFoundation ZcashFoundation deleted a comment from codecov bot Jul 24, 2020
@dconnolly dconnolly marked this pull request as ready for review July 25, 2020 22:50
@dconnolly dconnolly requested a review from a team July 25, 2020 22:51
@dconnolly
Copy link
Contributor

I want to get more tests in here but this is basically ready for review, and I've touched a lot of files so better to get started. 😅

@dconnolly dconnolly changed the title [WIP] Notes, note commitments, note commitment trees, nullifiers Notes, commitments, nullifiers, etc Jul 25, 2020
This was linked to issues Jul 28, 2020
Implement Sapling Note Commitment Function #274
Closed
Abstract MerkleCRH^Sapling Hash Function into its own function #330
Closed
Abstract MerkleCRH^Sprout Hash Function into its own function #329
Closed
dconnolly and others added 19 commits August 14, 2020 05:22
@dconnolly
impl From<&NullifierDerivingKey>, use that to derive Sapling Nullifier
e983ac6
@dconnolly
Support nullifier derivation from borrowed Spending, NullifierDerivin…
06707f0 
…g keys
@dconnolly
Accept an Amount<NonNegative> for the value arg of a ValueCommitment …
966a954 
…constructor
@dconnolly
Move Pedersen hash functions to their own submodule
0ed2dcb
@dconnolly
Remove Zcash(De)Serialize impls for *Commitments
4ebee6b
@dconnolly
Impl TryFrom for Commitments, call from impl ZcashDeserialize
abf8a35
@dconnolly
Add 32byte and 64 bytes convenience writer methods to WriteExt
0b4f232
@dconnolly
Use convenience Reader/Writer methods to only use From/Into for nulli…
92ab9f0 
…fer serialization

And thus remove duplicative Zcash(De)Serialization impls
@dconnolly
Defer to From/Into [u8; 32] vs Zcash(De)Serialize for sprout::NoteCom…
1dcde87 
…mitments
@dconnolly
Impl TryFrom's for Diversifier and use those to construct Sapling Not…
46f1ec8 
…eCommitments
@dconnolly @hdevalence
Add note about whether sign checks in Amount -> Fr conversion matter
e8aef93 
Co-authored-by: Henry de Valence <hdevalence@hdevalence.ca>
@dconnolly
Add Sapling EphemeralPublicKey type that wraps jubjub::AffinePoint
fe35576
@dconnolly
Tidy JoinSplit nullifiers deserialization
09896d9
@dconnolly
Refine JoinSplit::anchor to be a sprout::NoteTreeRootHash type
8db4c54
@dconnolly
Clarify docstring on NoteCommitment::new()
6fef07e
@dconnolly
Add a TODO about caching Pedersen hash generator points
48f9194
@dconnolly
Whoops forgot to add sprout::NoteTreeRootHash
c4b05b5
@dconnolly
Serialize Amount to bytes using byteorder::LittleEndian
b53909d
@dconnolly
Impl ZcashDeserialize for jubjub::Fq, use in transaction deserialization
f1004de
@dconnolly dconnolly force-pushed the sprout-note-commitment branch 3 times, most recently from cde3d5b to d97208b Compare August 14, 2020 05:33
@dconnolly
Use the jubjub::AffinePoint in the canonical, encoded little-endian b…
4e4e468 
…yte form in

Pedersen tests

Keeps the librustzcash test vectors with their big-endian byte order
as comments, for greppability.
@dconnolly dconnolly merged commit 616d82f into main Aug 14, 2020
@dconnolly dconnolly deleted the sprout-note-commitment branch August 14, 2020 06:04
@hdevalence hdevalence mentioned this pull request Aug 14, 2020
Closed
@dconnolly dconnolly mentioned this pull request Mar 5, 2021
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 left review comments

@daira daira daira left review comments

@dconnolly dconnolly dconnolly approved these changes

@hdevalence hdevalence Awaiting requested review from hdevalence

Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Milestone
Transaction Validation
5 participants
@yaahc @dconnolly @hdevalence @daira @teor2345