-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIP-221: Validate chain history commitments in the non-finalized state #2135
Labels
C-enhancement
Category: This is an improvement
NU-5
Network Upgrade: NU5 specific tasks
S-needs-design
Status: Needs a design decision
Milestone
Comments
mpguerra
added
NU Genesis
Network Upgrade: Genesis block specific tasks
C-enhancement
Category: This is an improvement
S-needs-triage
Status: A bug report needs triage
NU-5
Network Upgrade: NU5 specific tasks
labels
May 11, 2021
1 task
mpguerra
added
S-needs-design
Status: Needs a design decision
P-Medium
and removed
NU Genesis
Network Upgrade: Genesis block specific tasks
S-needs-triage
Status: A bug report needs triage
labels
May 11, 2021
9 tasks
We need the sapling tree root for this change, so testing and full implementation are blocked by the sapling part of #1287. |
teor2345
changed the title
ZIP-221: Update Zebra state implementation for non-finalized chains
ZIP-221: Validate chain history in the non-finalized state
Jun 14, 2021
teor2345
changed the title
ZIP-221: Validate chain history in the non-finalized state
ZIP-221: Validate chain history commitments in the non-finalized state
Jun 14, 2021
2 tasks
3 tasks
Merged
3 tasks
3 tasks
2 tasks
#2396 does not actually close this ticket |
This was referenced Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Category: This is an improvement
NU-5
Network Upgrade: NU5 specific tasks
S-needs-design
Status: Needs a design decision
Is your feature request related to a problem?
In order to implement ZIP-221 in Zebra, we will need to update our implementation of Zebra state for non-finalized chains, and validate chain history commitments in the non-finalized state.
Describe the solution you'd like
Maintaining history
Chain
typeTree::append_leaf
Tree::truncate_leaf
Tree::append_leaf
Contextual validation of non-checkpoint blocks
check
modulecommit_block
andcommit_new_chain
, right before we add the block to the chainBlockError
variantDescribe alternatives you've considered
We could re-calculate each side-chain starting from the finalized tip.
We could keep the (non-finalized) leaf nodes for each non-finalized block, and share forked block state using
Arc
orim
. However this:Additional context
See #2091 (comment) for further details
The text was updated successfully, but these errors were encountered: