-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add final sapling root test vectors #2243
Conversation
Also tidy some formatting and imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This comment has been minimized.
This comment has been minimized.
This makes the test vectors match the byte order in the block header, rather than the zcashd RPC responses.
Previously, Zebra expected this reserved field to be all zeroes, but some mainnet and testnet blocks had other values.
History roots are excluded from these tests, because they require contextual validation.
I've made the following changes to this PR:
@conradoplg feel free to approve and merge this PR so you can keep on going with #2227. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works with the code from #2227 😁
Motivation
In #2227, we need final sapling roots to test the chain history integration.
API Specifications
This PR contains data from
zcashd
'sz_gettreestate
RPC:https://zcash-rpc.github.io/z_gettreestate.html
Solution
Add test vectors:
Fix and test block header commitments:
Review
@conradoplg is waiting on these test vectors for #2227.
Reviewer Checklist
Follow Up Work
Implement and test final sapling roots in Zebra #1287