Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback for older node versions that have followed a legacy chain #1820

Closed
teor2345 opened this issue Feb 25, 2021 · 2 comments
Closed

Rollback for older node versions that have followed a legacy chain #1820

teor2345 opened this issue Feb 25, 2021 · 2 comments
Assignees
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped I-consensus Zebra breaks a Zcash consensus rule I-hang A Zebra component stops responding to requests NU-5 Network Upgrade: NU5 specific tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Feb 25, 2021

Motivation

If an old version of Zebra isn't upgraded before a network upgrade, we need to rollback or delete the database.

Solution

Let's do this work in a few separate parts.

Alternatives

We don't need to do the legacy chain check until after the highest checkpoint in Zebra's checkpoint list. (Regardless of Zebra's checkpoint config.) But it's easier to test if we do it as early as possible.

We could:

This might not be possible on Windows, it could leave some resources open, and we'd need to guard against multiple restarts.

Related Work

This change is part of ZIP-200 and #337.

These tickets might also be related:

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium I-consensus Zebra breaks a Zcash consensus rule I-hang A Zebra component stops responding to requests labels Feb 25, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Mar 9, 2021
@teor2345
Copy link
Contributor Author

Re-adding this to NU5, because the longer NU5 timelines make it more likely that outdated deployed Zebra nodes will pass NU5 activation, but not have the activation heights set.

@mpguerra mpguerra added this to the 2021 Sprint 12 milestone May 6, 2021
@mpguerra mpguerra added the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label Jun 15, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 12 milestone Jun 16, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Jul 7, 2021

This was closed by ticket #2308 and PR #2366.

@teor2345 teor2345 closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped I-consensus Zebra breaks a Zcash consensus rule I-hang A Zebra component stops responding to requests NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

No branches or pull requests

3 participants