Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Block in State Checks to Downloaders #2307

Closed
3 tasks
oxarbitrage opened this issue Jun 15, 2021 · 1 comment
Closed
3 tasks

Move Block in State Checks to Downloaders #2307

oxarbitrage opened this issue Jun 15, 2021 · 1 comment
Assignees
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Jun 15, 2021

Move the "block is in the state" checks to the downloaders:

  • in the sync downloader, check if the block is in the state after downloading it
  • in the inbound downloader, check if the block is in the state after downloading it
  • delete the "block in state" check from the BlockVerifier

We probably want to keep the "block in state" check in the checkpoint verifier. There can be a delay between the downloader sending blocks, and the checkpoint verifier receiving them, due to buffers and service readiness. And I'm pretty sure the checkpoint verifier can panic on duplicate blocks.

This is part of a split of #1820

@oxarbitrage oxarbitrage added this to the 2021 Sprint 12 milestone Jun 15, 2021
@oxarbitrage oxarbitrage added A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks P-Medium C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jun 15, 2021
@oxarbitrage oxarbitrage self-assigned this Jun 16, 2021
@oxarbitrage oxarbitrage removed the S-needs-triage Status: A bug report needs triage label Jun 16, 2021
@teor2345 teor2345 removed this from the 2021 Sprint 15 milestone Jul 7, 2021
@teor2345
Copy link
Contributor

teor2345 commented Jul 7, 2021

This work was part of an obsolete design, we don't need to do it any more.

@teor2345 teor2345 closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants