Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clippy pass to CI and decide on lints to use. #209

Closed
hdevalence opened this issue Jan 30, 2020 · 1 comment · Fixed by #224
Closed

Add a clippy pass to CI and decide on lints to use. #209

hdevalence opened this issue Jan 30, 2020 · 1 comment · Fixed by #224
Assignees

Comments

@hdevalence
Copy link
Contributor

Doing this for the first time will probably require making a bunch of changes to the source to make it satisfy the lints.

As indicated by the name, clippy is meant to err on the side of annoyance, so not all lints will be appropriate at all times. So we need to decide as a project how we want to handle lints. One option is to allow clippy lints to fail (i.e., don't block CI on them), and another is to add annotations throughout the source to disable them where they occur. I don't have a super strong preference, but my initial preference is to do the latter option, making clippy failures a CI failure but allowing disabling specific lints in-place with annotations.

@hdevalence hdevalence self-assigned this Jan 30, 2020
@dconnolly
Copy link
Contributor

dconnolly commented Jan 30, 2020

skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants