Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIP-221: Add Orchard support to history merkle mountain range using librustzcash #2283

Closed
conradoplg opened this issue Jun 11, 2021 · 0 comments · Fixed by #2531
Closed

ZIP-221: Add Orchard support to history merkle mountain range using librustzcash #2283

conradoplg opened this issue Jun 11, 2021 · 0 comments · Fixed by #2531
Labels
C-enhancement Category: This is an improvement
Milestone
2021 Sprint 15

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Jun 11, 2021 •
edited
Loading

Motivation

#2132 added integration with librustzcash for the MMR tree specified in ZIP-221. However, it's missing Orchard support since that is still being reviewed in librustzcash (zcash/librustzcash#401)

Specifications

ZIP-221

Designs

See #2132 for the overall design of the librustzcash integration

Solution

Change zcash_history.rs to add Orchard support after the librustzcash PR is merged.

Also change history_tree.rs to reflect the underlying changes.

Alternatives

None

Related Work

Follow up to #2132
@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jun 11, 2021
This was referenced Jun 11, 2021
Closed
Closed
@conradoplg conradoplg mentioned this issue Jun 17, 2021
Merged
3 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jun 21, 2021
@conradoplg conradoplg mentioned this issue Jun 25, 2021
Merged
3 tasks
@mpguerra mpguerra added the S-blocked Status: Blocked on other tasks label Jul 13, 2021
@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Jul 26, 2021
@conradoplg conradoplg mentioned this issue Jul 26, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: This is an improvement
Projects
None yet
Milestone
2021 Sprint 15
Development

Successfully merging a pull request may close this issue.

ZIP-221: Add Orchard support to history tree ZcashFoundation/zebra
3 participants
@conradoplg @mpguerra @teor2345