Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIP-221: Block Header Chain History Commitment #1567

Closed
3 tasks done
teor2345 opened this issue Jan 8, 2021 · 5 comments
Closed
3 tasks done

ZIP-221: Block Header Chain History Commitment #1567

teor2345 opened this issue Jan 8, 2021 · 5 comments
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-5 Network Upgrade: NU5 specific tasks S-needs-design Status: Needs a design decision

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jan 8, 2021 •
edited
Loading

This implementation is done, it just has tests left.

Is your feature request related to a problem? Please describe.

The Heartwood network upgrade changes the meaning of the Commitment block header field:
https://zips.z.cash/zip-0221

Describe the solution you'd like

The Commitment enum variants have already been implemented.

Additional context

This is a required validation rule for Heartwood and later network upgrades. It is modified by ZIP-244 in NU5.
@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU-3 Heartwood Network Upgrade: Heartwood specific tasks C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jan 8, 2021
@teor2345 teor2345 mentioned this issue Jan 8, 2021
Closed
9 tasks
@mpguerra
Copy link
Contributor

Is this issue in anyway related to #881 ?

@teor2345 teor2345 mentioned this issue Jan 21, 2021
Closed
4 tasks
@teor2345
Copy link
Contributor Author

Is this issue in anyway related to #881 ?

#881 is a refactor of the RootHash code, this ticket implements the latest (Heartwood) variant in the code.

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 2, 2021
@mpguerra mpguerra mentioned this issue Mar 5, 2021
Closed
This was referenced Mar 29, 2021
Closed
Merged
@teor2345 teor2345 added this to the 2021 Sprint 7 milestone Mar 31, 2021
@teor2345 teor2345 mentioned this issue Apr 6, 2021
Merged
@mpguerra mpguerra added the S-needs-design Status: Needs a design decision label Apr 6, 2021
@teor2345 teor2345 changed the title ZIP-221: FlyClient - Block Header Changes ZIP-221: FlyClient - Block Header Chain History Commitment Apr 6, 2021
@teor2345 teor2345 changed the title ZIP-221: FlyClient - Block Header Chain History Commitment ZIP-221: Block Header Chain History Commitment Apr 6, 2021
This was referenced Apr 21, 2021
Closed
Closed
@teor2345 teor2345 changed the title ZIP-221: Block Header Chain History Commitment ZIP-221: Implement Block Header Chain History Commitment Apr 30, 2021
@teor2345 teor2345 added the NU-5 Network Upgrade: NU5 specific tasks label Apr 30, 2021
@teor2345 teor2345 mentioned this issue Apr 30, 2021
Closed
1 task
@teor2345
Copy link
Contributor Author

I split out the design into #2091, and the optional sapling root check into #2092.

@mpguerra mpguerra mentioned this issue May 5, 2021
Closed
1 task
@mpguerra mpguerra added the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label May 6, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 10 milestone May 6, 2021
@teor2345 teor2345 changed the title ZIP-221: Implement Block Header Chain History Commitment ZIP-221: Block Header Chain History Commitment May 11, 2021
@conradoplg
Copy link
Collaborator

I think #2283 will be part of this

@teor2345
Copy link
Contributor Author

This implementation is done, it just has tests left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped NU-3 Heartwood Network Upgrade: Heartwood specific tasks NU-5 Network Upgrade: NU5 specific tasks S-needs-design Status: Needs a design decision
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@conradoplg @mpguerra @teor2345