Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Block Header FinalSaplingRoot #2092

Closed
1 task
teor2345 opened this issue Apr 30, 2021 · 1 comment
Closed
1 task

Implement Block Header FinalSaplingRoot #2092

teor2345 opened this issue Apr 30, 2021 · 1 comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-1 Sapling Network Upgrade: Sapling specific tasks

Comments

@teor2345
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

The Commitment enum variants have already been implemented.

Additional context

This historical validation rule was used in the Sapling and Blossom network upgrades. But it is replaced by the ChainHistoryRoot in Heartwood. Since Zebra checkpoints on Canopy, we do not need to implement this rule.

But it might be useful while we're testing ZIP-221 (#1567) or ZIP-244 (#2048).

@teor2345 teor2345 added A-consensus Area: Consensus rule updates NU-1 Sapling Network Upgrade: Sapling specific tasks A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Optional labels Apr 30, 2021
@teor2345 teor2345 changed the title Sapling: Implement Block Header Chain History Commitment Sapling: Implement Block Header FinalSaplingRoot May 3, 2021
@teor2345 teor2345 changed the title Sapling: Implement Block Header FinalSaplingRoot Implement Block Header FinalSaplingRoot May 3, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label May 4, 2021
@mpguerra
Copy link
Contributor

Both ZIP-221 (#1567) or ZIP-244 (#2048) are already implemented. If we want to do this again at some point in the future we should re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-1 Sapling Network Upgrade: Sapling specific tasks
Projects
None yet
Development

No branches or pull requests

2 participants