Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable beta Rust tests in CI #2541

Closed
teor2345 opened this issue Jul 29, 2021 · 3 comments · Fixed by #4637
Closed

Re-enable beta Rust tests in CI #2541

teor2345 opened this issue Jul 29, 2021 · 3 comments · Fixed by #4637
Assignees
@gustavovalverde
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 29, 2021 •
edited
Loading

Motivation

We want to test Zebra with the next Rust release candidate, so we can report any compilation bugs and get them fixed.

On 29 July, Zebra's beta Rust tests started failing, due to a beta rust bug (rust-lang/rust#87483).

But the stable CI tests and beta zebra-chain build were fine.

Actions

We disabled the beta Rust tests in PR #2542.

We should re-enable beta Rust:
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles S-needs-triage Status: A bug report needs triage P-Medium labels Jul 29, 2021
@teor2345 teor2345 changed the title Try re-enabling docs build and deploy Try re-enabling beta Rust tests and docs in CI Jul 29, 2021
@teor2345 teor2345 added the A-infrastructure Area: Infrastructure changes label Jul 29, 2021
@teor2345 teor2345 mentioned this issue Jul 29, 2021
Merged
@teor2345 teor2345 added this to the 2021 Sprint 16 milestone Jul 29, 2021
@teor2345 teor2345 changed the title Try re-enabling beta Rust tests and docs in CI Try re-enabling beta Rust tests in CI Jul 29, 2021
@teor2345
Copy link
Contributor Author

I removed docs from this ticket, because they aren't impacted by the beta rust bug.

@teor2345
Copy link
Contributor Author

I confirmed that this Rust PR fixes the test build failure we're seeing: rust-lang/rust#87483

So we should be good to re-enable beta once it has been backported.

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Aug 16, 2021
@teor2345
Copy link
Contributor Author

This has now been backported: rust-lang/rust#88190

@mpguerra mpguerra removed this from the 2021 Sprint 20 milestone Sep 27, 2021
@mpguerra mpguerra added this to the 2021 Sprint 21 milestone Oct 13, 2021
@teor2345 teor2345 added P-Low and removed P-Medium labels Oct 13, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 21 milestone Oct 14, 2021
@teor2345 teor2345 changed the title Try re-enabling beta Rust tests in CI Re-enable beta Rust tests in CI May 26, 2022
@gustavovalverde gustavovalverde mentioned this issue Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): add beta rust to CI ZcashFoundation/zebra
3 participants
@mpguerra @teor2345 @gustavovalverde