Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Rust beta tests in CI, due to a Rust bug #2542

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jul 29, 2021

Motivation

On 29 July, Zebra's tests started failing on beta Rust (rust-lang/rust#87483).

But the stable CI tests and beta zebra-chain build were fine.

Solution

Disable the Rust beta tests in the CI matrix, but keep stable tests, and stable and beta zebra-chain builds.

Follow Up

We should try re-enabling beta tests at some point (#2541).


This change is Reviewable

@teor2345 teor2345 added C-bug Category: This is a bug A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles P-High I-integration-fail Continuous integration fails, including build and test failures labels Jul 29, 2021
@teor2345 teor2345 added this to the 2021 Sprint 15 milestone Jul 29, 2021
@teor2345 teor2345 self-assigned this Jul 29, 2021
@teor2345 teor2345 merged commit e2a3a38 into main Jul 29, 2021
@teor2345 teor2345 deleted the disable-beta-rust branch July 29, 2021 03:02
@teor2345
Copy link
Contributor Author

Admin-merged because this blocks CI and PRs for everyone on the team.

@teor2345 teor2345 mentioned this pull request Jul 29, 2021
6 tasks
@daira
Copy link
Contributor

daira commented Jul 29, 2021

What is the bug?

@dconnolly
Copy link
Contributor

dconnolly commented Jul 29, 2021

What is the bug?

@daira

 internal compiler error: unexpected concrete region in borrowck: ReStatic

mpguerra added a commit that referenced this pull request Jul 29, 2021
mpguerra added a commit that referenced this pull request Jul 29, 2021
* Draft CHANGELOG for Zebra 1.0.0-alpha.14

* Add PR #2533 to CHANGELOG

* Apply suggestions from code review

Co-authored-by: teor <teor@riseup.net>

* Remove entry about updating the changelog

* move #2497

* add #2529

* Add a missing space

* Add #2458, #2525, #2486, #2542 and  #2539 to CHANGELOG

Co-authored-by: teor <teor@riseup.net>
Co-authored-by: Deirdre Connolly <deirdre@zfnd.org>
@teor2345
Copy link
Contributor Author

teor2345 commented Jul 29, 2021

@daira we think it's rust-lang/rust#87483 , but I haven't checked if the Rust PR fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants