CHANGELOG for Zebra 1.0.0-alpha.14 #2538
Conversation
Co-authored-by: teor <teor@riseup.net>
There was a problem hiding this comment.
The changelog looks good.
The Google cloud build is failing because the branch name in this PR contains ., and uppercase letters. (See #2418.)
We can admin-merge this PR as a workaround. Since the failure is caused by the branch name, it should pass after it is merged to main.
Edit: Maybe it could be the branch name length or uppercase letters? #2537 passes.
|
One more! |
|
I merged #2542 to fix CI failures |
|
I merged #2486 so I could get started on other work. |
|
Also #2525, sorry about all the changes! |
I feel like I've tried all possible combinations, I thought the branch name length was fine, maybe it is the uppercase. |
|
going to admin merge once CI ( minus pull-request check) passes and before anything else is merged :P |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 9 unresolved discussions (waiting on @mpguerra and @teor2345)
CHANGELOG.md, line 26 at r1 (raw file):
Previously, teor2345 (teor) wrote…
rustfmtisn't interesting enough to make the changelog
Done.
CHANGELOG.md, line 28 at r1 (raw file):
Previously, mpguerra (Pili Guerra) wrote…
ah, I should have looked into the PR to see what it did. FWIW, I don't think it's very interesting either and I have removed it from the PR
Done.
CHANGELOG.md, line 34 at r1 (raw file):
Previously, teor2345 (teor) wrote…
Oops, these are mine, they weren't very clear
- Decrease the number of randomised test cases in zebra-state (#2521, #2513) - Make nullifier tests consistent with UTXO tests (#2513)
Done.
CHANGELOG.md, line 35 at r1 (raw file):
Previously, teor2345 (teor) wrote…
Probably doesn't matter that much
Done.
CHANGELOG.md, line 39 at r1 (raw file):
Previously, teor2345 (teor) wrote…
Oops, this was me again
- Clarify a variable name and check for overflow in new_ordered_outputs (#2510)
Done.
CHANGELOG.md, line 40 at r1 (raw file):
Previously, mpguerra (Pili Guerra) wrote…
Done in 32bd8ee
Done.
CHANGELOG.md, line 41 at r1 (raw file):
Previously, teor2345 (teor) wrote…
I had to go look up this PR to work out what part of orchard we fixed
- Update Orchard keys, hashes, and note commitments to match Zcash test vectors (#2445)
Done.
CHANGELOG.md, line 42 at r1 (raw file):
Previously, teor2345 (teor) wrote…
Clippy fixes aren't that interesting
Done.
CHANGELOG.md, line 20 at r5 (raw file):
Previously, teor2345 (teor) wrote…
Add a missing space
- Add `proptest-impl` feature to `zebra-state` crate to help simplify tests (#2529)
Done.
Motivation
Update CHANGELOG for Zebra 1.0.0-alpha.14 release
Review
@ZcashFoundation/zebra-team
Reviewer Checklist
Follow Up Work
Once release version update PR is merged:
This change is