Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test History Tree errors in finalized state #2559

Closed
Tracked by #745
conradoplg opened this issue Aug 2, 2021 · 1 comment
Closed
Tracked by #745

Test History Tree errors in finalized state #2559

conradoplg opened this issue Aug 2, 2021 · 1 comment
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Aug 2, 2021

Motivation

#2553 adds the ZIP-221 History Tree to the finalized state, but there are no particular tests for it (other the running the node and checking if it syncs correctly).

Implement tests to test it, in particular the error paths. See https://github.com/ZcashFoundation/zebra/pull/2553/files#r680668957 for context:

I think we'll need to make them cached state tests (and work out how to feed them corrupt blocks), or do significant refactoring, or wait until after NU5 testnet activation.

One quick way to do this test is:

  • add the NU5 testnet activation block and a few following blocks to the Zebra test vectors
  • test that the finalized state works when given those blocks
    • pre-populate the finalized state with the UTXOs deleted by those blocks, the NU5 - 1 note commitment trees, and whatever other state is required for the tests to pass
  • modify the blocks for each kind of error

Specifications

N/A

Designs

N/A

Related Work

Follow up to #2553

@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Aug 2, 2021
@mpguerra mpguerra added the C-cleanup Category: This is a cleanup label Aug 5, 2021
@mpguerra mpguerra added this to the 2021 Sprint 21 milestone Aug 13, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Aug 16, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 22 milestone Oct 13, 2021
@teor2345
Copy link
Contributor

teor2345 commented Jun 2, 2022

This seemed to work correctly on testnet before the second NU5 activation.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

3 participants