Security: Replace older duplicate queued checkpoint blocks with the latest block's data #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
teor2345
force-pushed
the
checkpoint-verifier-efficient
branch
from
850b9ed to
52cef8c
Compare
teor2345
force-pushed
the
replace-duplicate-checkpoint-block
branch
from
4ac4984 to
c17baba
Compare
teor2345
changed the title
teor2345
changed the title
teor2345
force-pushed
the
checkpoint-verifier-efficient
branch
from
14dde60 to
279b79f
Compare
teor2345
force-pushed
the
replace-duplicate-checkpoint-block
branch
from
c17baba to
0adb91f
Compare
We don't check the authorizing data hash until checkpoint blocks reach the state. So signatures, proofs, or scripts could be different, even if the block hash is the same.
teor2345
force-pushed
the
replace-duplicate-checkpoint-block
branch
from
0adb91f to
2bdbbc0
Compare
|
The cache action did not output anything, and was cancelled after 30 minutes: |
dconnolly
approved these changes
Aug 31, 2021
conradoplg
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't check the authorizing data hash until checkpoint blocks reach the state.
So signatures, proofs, or scripts could be different, even if the block hash is the same.
This is unexpected work in sprint 17.
Specifications
https://zips.z.cash/zip-0244
Solution
We'll write tests for these kinds of block modifications in #2559.
Review
@conradoplg worked on the authorization hash security design.
This fix isn't urgent.
This PR is based on PR #2696, so it might need a rebase after that PR merges.Reviewer Checklist