-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Zebra send notfound
, and use received notfound
to finish requests
#2726
Closed
Tracked by
#2309
Labels
A-network
Area: Network protocol updates or fixes
A-rust
Area: Updates to Rust code
C-design
Category: Software design work
C-enhancement
Category: This is an improvement
Comments
teor2345
added
A-network
Area: Network protocol updates or fixes
A-rust
Area: Updates to Rust code
C-design
Category: Software design work
C-enhancement
Category: This is an improvement
P-Medium
and removed
P-Medium
labels
Sep 2, 2021
4 tasks
3 tasks
3 tasks
This is required for #2156 - Zebra should send |
teor2345
changed the title
Work out when Zebra should send
Make Zebra send Dec 7, 2021
notfound
, and how it should handle received notfound
notfound
, and use received notfound
to finish requests
This was referenced Dec 8, 2021
@teor2345 can you please add your estimate to this issue when you get a chance, probably no need to do a planning poker session with the whole team since you're already working on it |
This was referenced Jan 30, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-network
Area: Network protocol updates or fixes
A-rust
Area: Updates to Rust code
C-design
Category: Software design work
C-enhancement
Category: This is an improvement
Motivation
zcashd
and Zebra don't actually neednotfound
messages:https://github.com/zcash/zcash/blob/e7b425298f6d9a54810cb7183f00be547e4d9415/src/main.cpp#L5632
https://github.com/ZcashFoundation/zebra/blob/main/zebra-network/src/peer/connection.rs#L115
But Zebra should send
notfound
as much as possible, so thatinv
routing works efficiently.This also helps with testing #2156.
We might also want to use them for SPV clients - does the Zcash network have any of those?
Suggested Solution
notfound
so Zebra peers know that we've replied with all the transactions/blocks we havenotfound
when it's waiting for more blocks or transactions (we might already do this)Rejected Alternatives
zcashd
doesn't do this, and it isn't really supported by the protocol.notfound
to tell peers when our mempool is emptynotfound
when waiting for aMempoolTransactionIds
reply, rather than timing out because there is no replyThe text was updated successfully, but these errors were encountered: