Respond to inbound TransactionsById with mempool content
#2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
reviewed
Sep 2, 2021
dconnolly
reviewed
Sep 2, 2021
dconnolly
reviewed
Sep 2, 2021
dconnolly
previously approved these changes
Sep 2, 2021
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we have a mempool we can reply to
TransactionsByIdrequests.This will close #1077
Solution
Respond to the
TransactionsByIdwith mempool content.Review
This is pretty straightforward after we made the first mempool message in #2720. I used the same test to avoid repeating a bunch of setup code but this can be changed if it is more clear to have separated ones.
@jvff already reviewed #2720 and this is following the same line so is a good candidate but i think anyone working in the mempool can review as well.
Reviewer Checklist
Follow Up Work
In bitcoin implementation there is an additional
notfoundresponse to this message with the non found hashes. It seems this is not needed in zcash network (#1077 (comment)) however we might need more research. #2726 was opened for this.