Reply to Request::MempoolTransactionIds with mempool content
#2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
commented
Sep 1, 2021
oxarbitrage
commented
Sep 1, 2021
jvff
previously approved these changes
Sep 1, 2021
|
Thanks @jvff , this was supposed to be a draft PR but i submitted it late yesterday and didn't realized it ended up as a normal one. Anyway, will do your suggestions asap. Thanks again. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that we have a mempool we can start responding with it contents to some inbound messages.
Close #1083 when merged.
Solution
This is the easier message that responds with the ids available in the mempool. Most of the work is in the test.
Review
I used some code from other tests made by @jvff so i think it will be a good candidate to the an initial review. On the other hand as we are all in mempool pretty much anyone can review so feel free to send feedback.
Reviewer Checklist