Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in/wrap Curve25519 for Sprout key agreement #303

Closed
dconnolly opened this issue Mar 10, 2020 · 2 comments · Fixed by #317
Closed

Pull in/wrap Curve25519 for Sprout key agreement #303

dconnolly opened this issue Mar 10, 2020 · 2 comments · Fixed by #317
Labels
A-dependencies Area: Dependency file updates

Comments

@dconnolly
Copy link
Contributor

image

Probably curve25519-dalek

https://zips.z.cash/protocol/protocol.pdf#concretesproutkeyagreement
@dconnolly dconnolly added A-dependencies Area: Dependency file updates Poll::Ready labels Mar 10, 2020
@hdevalence hdevalence mentioned this issue Mar 10, 2020
Closed
@dconnolly dconnolly linked a pull request Mar 24, 2020 that will close this issue
Sprout keys and addresses #317
Merged
@daira
Copy link
Contributor

daira commented Mar 28, 2020

Was this ticket intended to include note encryption? I don't see any implementation here.

@daira
Copy link
Contributor

daira commented Mar 28, 2020 •
edited
Loading

Oh that's #181. Just pulling in x25519_dalek is sufficient for key agreement. I was confused because the above quote from the spec includes the KDF, which is not done yet.

@dconnolly dconnolly mentioned this issue Mar 5, 2021
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: Dependency file updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sprout keys and addresses ZcashFoundation/zebra
2 participants
@dconnolly @daira